lkml.org 
[lkml]   [2018]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 1/3] dt-bindings: mmc: tegra: Add pinctrl for pad drive strength config
Date
Hi Rob,

>> Add pinctrl for 3V3 and 1V8 pad drive strength configuration for
>> Tegra210 sdmmc which has pad configuration registers in the pinmux
>> reigster domain.
>
> typo
>
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt | 6
>> +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
>> b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
>> index 32b4b4e41923..2cecdc71d94c 100644
>> --- a/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
>> +++ b/Documentation/devicetree/bindings/mmc/nvidia,tegra20-sdhci.txt
>> @@ -39,12 +39,16 @@ sdhci@c8000200 {
>> bus-width = <8>;
>> };
>>
>> -Optional properties for Tegra210 and Tegra186:
>> +Optional properties for Tegra210, Tegra186 and Tegra194:
>
>Adding Tegra194, but this patch concerns Tegra210...
Yes this is mainly part of Tegra210 Patch but pinctrls sdmmc-1v8 and sdmmc-3v3
also applies for Tegra194 and since it was not mentioned, added Tegra194 as well.
Does adding Tegra194 in this should come as separate patch?
>
>> - pinctrl-names, pinctrl-0, pinctrl-1 : Specify pad voltage
>> configurations. Valid pinctrl-names are "sdmmc-3v3" and "sdmmc-1v8"
>> for controllers supporting multiple voltage levels. The order of names
>> should correspond to the pin configuration states in pinctrl-0 and
>> pinctrl-1.
>> +- pinctrl-names : "sdmmc-3v3-drv" and "sdmmc-1v8-drv" are applicable
>> +for
>
>These are in addition to the previous values?
Yes these are additional pinctrl states for pad drive settings which are in pinmux
Domain and are applicable during calibration process.
>
>> + Tegra210 where pad config registers are in the pinmux register
>> + domain for pull-up-strength and pull-down-strength values
>> + configuration when using pads at 3V3 and 1V8 levels.
>> - nvidia,only-1-8-v : The presence of this property indicates that the
>> controller operates at a 1.8 V fixed I/O voltage.
>> - nvidia,pad-autocal-pull-up-offset-3v3,
>> --
>> 2.7.4
>>

Thanks & Regards,
sowjanya

\
 
 \ /
  Last update: 2018-12-29 01:09    [W:0.063 / U:57.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site