lkml.org 
[lkml]   [2018]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dsa: return error code upstream
From
Date
Le 12/27/18 à 4:22 PM, David Miller a écrit :
> From: Kangjie Lu <kjlu@umn.edu>
> Date: Tue, 25 Dec 2018 22:08:18 -0600
>
>> Both bcm_sf2_sw_indir_rw and mdiobus_write_nested could fail, so let's
>> return their error codes upstream.
>>
>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>
> Applied with Subject line adjusted as per Florian's feedback.
>

Thanks, technically bcm_sf2_sw_indir_rw() cannot fail and checking its
return value in the write (op == 0) case will always lead to returning 0
anyway. In case this ever changes in the future, we should be more
future proof with that change anyway.
--
Florian

\
 
 \ /
  Last update: 2018-12-28 02:07    [W:0.057 / U:13.492 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site