Messages in this thread | | | Date | Wed, 26 Dec 2018 11:54:32 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH] drm/bridge/panel: Remove duplicate header |
| |
Hi Brajeswar
> On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote: > > Remove drm/drm_panel.h which is included more than once > > > > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com> > > --- > > drivers/gpu/drm/bridge/panel.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > index 7cbaba213ef6..402b318eeeb2 100644 > > --- a/drivers/gpu/drm/bridge/panel.c > > +++ b/drivers/gpu/drm/bridge/panel.c > > @@ -15,7 +15,6 @@ > > #include <drm/drm_crtc_helper.h> > > #include <drm/drm_encoder.h> > > #include <drm/drm_modeset_helper_vtables.h> > > -#include <drm/drm_panel.h> > > While at it, how about sorting headers alphabetically to make sure this won't > happen again ?
Even better would be to address the todo item: "Clean up the DRM header mess" (see Documentation/gpu/todo.rst)
In other words - replace the include of "drmP.h" with the relevant header files. Sorted, as suggested by Laurent.
Sam
| |