lkml.org 
[lkml]   [2018]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 48/59] lan78xx: Resolve issue with changing MAC address
    Date
    From: Jason Martinsen <jasonmartinsen@msn.com>

    [ Upstream commit 15515aaaa69659c502003926a2067ee76176148a ]

    Current state for the lan78xx driver does not allow for changing the
    MAC address of the interface, without either removing the module (if
    you compiled it that way) or rebooting the machine. If you attempt to
    change the MAC address, ifconfig will show the new address, however,
    the system/interface will not respond to any traffic using that
    configuration. A few short-term options to work around this are to
    unload the module and reload it with the new MAC address, change the
    interface to "promisc", or reboot with the correct configuration to
    change the MAC.

    This patch enables the ability to change the MAC address via fairly normal means...
    ifdown <interface>
    modify entry in /etc/network/interfaces OR a similar method
    ifup <interface>
    Then test via any network communication, such as ICMP requests to gateway.

    My only test platform for this patch has been a raspberry pi model 3b+.

    Signed-off-by: Jason Martinsen <jasonmartinsen@msn.com>

    -----

    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/usb/lan78xx.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
    index e069b310d6a6..b62c41114e34 100644
    --- a/drivers/net/usb/lan78xx.c
    +++ b/drivers/net/usb/lan78xx.c
    @@ -2212,6 +2212,10 @@ static int lan78xx_set_mac_addr(struct net_device *netdev, void *p)
    ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
    ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi);

    + /* Added to support MAC address changes */
    + ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo);
    + ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_);
    +
    return 0;
    }

    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-26 23:45    [W:3.119 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site