lkml.org 
[lkml]   [2018]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 50/59] vxge: ensure data0 is initialized in when fetching firmware version information
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit f7db2beb4c2c6cc8111f5ab90fc7363ca91107b6 ]

    Currently variable data0 is not being initialized so a garbage value is
    being passed to vxge_hw_vpath_fw_api and this value is being written to
    the rts_access_steer_data0 register. There are other occurrances where
    data0 is being initialized to zero (e.g. in function
    vxge_hw_upgrade_read_version) so I think it makes sense to ensure data0
    is initialized likewise to 0.

    Detected by CoverityScan, CID#140696 ("Uninitialized scalar variable")

    Fixes: 8424e00dfd52 ("vxge: serialize access to steering control register")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/neterion/vxge/vxge-config.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/neterion/vxge/vxge-config.c b/drivers/net/ethernet/neterion/vxge/vxge-config.c
    index 6223930a8155..6f57b0b7d57a 100644
    --- a/drivers/net/ethernet/neterion/vxge/vxge-config.c
    +++ b/drivers/net/ethernet/neterion/vxge/vxge-config.c
    @@ -808,7 +808,7 @@ __vxge_hw_vpath_fw_ver_get(struct __vxge_hw_virtualpath *vpath,
    struct vxge_hw_device_date *fw_date = &hw_info->fw_date;
    struct vxge_hw_device_version *flash_version = &hw_info->flash_version;
    struct vxge_hw_device_date *flash_date = &hw_info->flash_date;
    - u64 data0, data1 = 0, steer_ctrl = 0;
    + u64 data0 = 0, data1 = 0, steer_ctrl = 0;
    enum vxge_hw_status status;

    status = vxge_hw_vpath_fw_api(vpath,
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-26 23:43    [W:2.813 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site