Messages in this thread | | | Date | Fri, 21 Dec 2018 13:28:24 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH v2 2/2] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race |
| |
On Tue, Dec 18, 2018 at 02:35:57PM -0800, Mike Kravetz wrote: > Instead of writing the required complicated code for this rare > occurrence, just eliminate the race. i_mmap_rwsem is now held in read > mode for the duration of page fault processing. Hold i_mmap_rwsem > longer in truncation and hold punch code to cover the call to > remove_inode_hugepages.
One of remove_inode_hugepages() callers is noticeably missing -- hugetlbfs_evict_inode(). Why?
It at least deserves a comment on why the lock rule doesn't apply to it.
-- Kirill A. Shutemov
| |