lkml.org 
[lkml]   [2018]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 07/19] mailbox: hi6220: Use device-managed registration API
    Date
    From: Thierry Reding <treding@nvidia.com>

    Get rid of some boilerplate driver removal code by using the newly added
    device-managed registration API.

    Cc: Leo Yan <leo.yan@linaro.org>
    Reviewed-by: Leo Yan <leo.yan@linaro.org>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    ---
    drivers/mailbox/hi6220-mailbox.c | 11 +----------
    1 file changed, 1 insertion(+), 10 deletions(-)

    diff --git a/drivers/mailbox/hi6220-mailbox.c b/drivers/mailbox/hi6220-mailbox.c
    index 4fa9803cd204..c32cbfaf223a 100644
    --- a/drivers/mailbox/hi6220-mailbox.c
    +++ b/drivers/mailbox/hi6220-mailbox.c
    @@ -349,7 +349,7 @@ static int hi6220_mbox_probe(struct platform_device *pdev)
    mbox->controller.txpoll_period = 5;
    }

    - err = mbox_controller_register(&mbox->controller);
    + err = devm_mbox_controller_register(dev, &mbox->controller);
    if (err) {
    dev_err(dev, "Failed to register mailbox %d\n", err);
    return err;
    @@ -360,14 +360,6 @@ static int hi6220_mbox_probe(struct platform_device *pdev)
    return 0;
    }

    -static int hi6220_mbox_remove(struct platform_device *pdev)
    -{
    - struct hi6220_mbox *mbox = platform_get_drvdata(pdev);
    -
    - mbox_controller_unregister(&mbox->controller);
    - return 0;
    -}
    -
    static struct platform_driver hi6220_mbox_driver = {
    .driver = {
    .name = "hi6220-mbox",
    @@ -375,7 +367,6 @@ static struct platform_driver hi6220_mbox_driver = {
    .of_match_table = hi6220_mbox_of_match,
    },
    .probe = hi6220_mbox_probe,
    - .remove = hi6220_mbox_remove,
    };

    static int __init hi6220_mbox_init(void)
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-20 18:22    [W:2.417 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site