lkml.org 
[lkml]   [2018]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 12/31] scsi: libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 5db6dd14b31397e8cccaaddab2ff44ebec1acf25 ]

    This commit addresses NULL pointer dereference in iscsi_eh_session_reset.
    Reference should not be made to session->leadconn when session->state is
    set to ISCSI_STATE_TERMINATE.

    Signed-off-by: Fred Herard <fred.herard@oracle.com>
    Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Reviewed-by: Lee Duncan <lduncan@suse.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/libiscsi.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
    index 857bf9417817..56441a5ec3d7 100644
    --- a/drivers/scsi/libiscsi.c
    +++ b/drivers/scsi/libiscsi.c
    @@ -2433,8 +2433,8 @@ int iscsi_eh_session_reset(struct scsi_cmnd *sc)
    failed:
    ISCSI_DBG_EH(session,
    "failing session reset: Could not log back into "
    - "%s, %s [age %d]\n", session->targetname,
    - conn->persistent_address, session->age);
    + "%s [age %d]\n", session->targetname,
    + session->age);
    spin_unlock_bh(&session->frwd_lock);
    mutex_unlock(&session->eh_mutex);
    return FAILED;
    --
    2.19.1


    \
     
     \ /
      Last update: 2018-12-20 10:47    [W:4.269 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site