lkml.org 
[lkml]   [2018]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 58/67] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs)
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 6e785302dad32228819d8066e5376acd15d0e6ba ]

    Missing a dependency. Shouldn't show cifs posix extensions
    in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1
    protocol) is disabled.

    Signed-off-by: Steve French <stfrench@microsoft.com>
    Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/cifs/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
    index abcd78e332fe..85dadb93c992 100644
    --- a/fs/cifs/Kconfig
    +++ b/fs/cifs/Kconfig
    @@ -133,7 +133,7 @@ config CIFS_XATTR

    config CIFS_POSIX
    bool "CIFS POSIX Extensions"
    - depends on CIFS_XATTR
    + depends on CIFS && CIFS_ALLOW_INSECURE_LEGACY && CIFS_XATTR
    help
    Enabling this option will cause the cifs client to attempt to
    negotiate a newer dialect with servers, such as Samba 3.0.5
    --
    2.19.1


    \
     
     \ /
      Last update: 2018-12-20 10:31    [W:4.084 / U:0.576 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site