lkml.org 
[lkml]   [2018]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 30/40] clk: mmp: Off by one in mmp_clk_add()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 2e85c57493e391b93445c1e0d530b36b95becc64 ]

    The > comparison should be >= or we write one element beyond the end of
    the unit->clk_table[] array.

    (The unit->clk_table[] array is allocated in the mmp_clk_init() function
    and it has unit->nr_clks elements).

    Fixes: 4661fda10f8b ("clk: mmp: add basic support functions for DT support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/mmp/clk.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/clk/mmp/clk.c b/drivers/clk/mmp/clk.c
    index 61893fe73251..18b6c9b55b95 100644
    --- a/drivers/clk/mmp/clk.c
    +++ b/drivers/clk/mmp/clk.c
    @@ -182,7 +182,7 @@ void mmp_clk_add(struct mmp_clk_unit *unit, unsigned int id,
    pr_err("CLK %d has invalid pointer %p\n", id, clk);
    return;
    }
    - if (id > unit->nr_clks) {
    + if (id >= unit->nr_clks) {
    pr_err("CLK %d is invalid\n", id);
    return;
    }
    --
    2.19.1


    \
     
     \ /
      Last update: 2018-12-20 10:22    [W:4.243 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site