lkml.org 
[lkml]   [2018]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 22/41] scsi: lpfc: lpfc_ct: Mark expected switch fall-throughs
    From
    Date
    Hi,

    Friendly ping:

    Who can ack or review this patch, please?

    Thanks
    --
    Gustavo

    On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote:
    > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    > where we are expecting to fall through.
    >
    > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    > ---
    > drivers/scsi/lpfc/lpfc_ct.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
    > index 6305ffeba7ea..b2b7fcc23654 100644
    > --- a/drivers/scsi/lpfc/lpfc_ct.c
    > +++ b/drivers/scsi/lpfc/lpfc_ct.c
    > @@ -3050,6 +3050,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
    > case SLI_MGMT_GHAT:
    > case SLI_MGMT_GRPL:
    > rsp_size = FC_MAX_NS_RSP;
    > + /* fall through */
    > case SLI_MGMT_DHBA:
    > case SLI_MGMT_DHAT:
    > pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
    > @@ -3062,6 +3063,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
    > case SLI_MGMT_GPAT:
    > case SLI_MGMT_GPAS:
    > rsp_size = FC_MAX_NS_RSP;
    > + /* fall through */
    > case SLI_MGMT_DPRT:
    > case SLI_MGMT_DPA:
    > pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;
    >

    \
     
     \ /
      Last update: 2018-12-19 23:50    [W:4.279 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site