lkml.org 
[lkml]   [2018]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 23/41] scsi: lpfc: lpfc_els: Mark expected switch fall-throughs
    From
    Date
    Hi,

    Friendly ping:

    Who can ack or review this patch, please?

    Thanks
    --
    Gustavo

    On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote:
    > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
    > where we are expecting to fall through.
    >
    > Addresses-Coverity-ID: 114978 ("Missing break in switch")
    > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    > ---
    > drivers/scsi/lpfc/lpfc_els.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
    > index 5c34bfa624ef..1f20c35e0f84 100644
    > --- a/drivers/scsi/lpfc/lpfc_els.c
    > +++ b/drivers/scsi/lpfc/lpfc_els.c
    > @@ -8649,6 +8649,7 @@ lpfc_cmpl_reg_new_vport(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
    > lpfc_nlp_put(ndlp);
    > return;
    > }
    > + /* fall through */
    >
    > default:
    > /* Try to recover from this error */
    >

    \
     
     \ /
      Last update: 2018-12-19 23:28    [W:4.781 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site