Messages in this thread | | | Date | Wed, 19 Dec 2018 20:34:55 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2/2] leds: lp5024: Add the LP5024/18 RGB LED driver |
| |
Hi!
> +static DEVICE_ATTR_WO(ctrl_bank_a_mix); > +static DEVICE_ATTR_WO(ctrl_bank_b_mix); > +static DEVICE_ATTR_WO(ctrl_bank_c_mix); > + > +static struct attribute *lp5024_ctrl_bank_attrs[] = { > + &dev_attr_ctrl_bank_a_mix.attr, > + &dev_attr_ctrl_bank_b_mix.attr, > + &dev_attr_ctrl_bank_c_mix.attr, > + NULL > +}; > +ATTRIBUTE_GROUPS(lp5024_ctrl_bank);
... > + > +static DEVICE_ATTR_WO(led1_mix); > +static DEVICE_ATTR_WO(led2_mix); > +static DEVICE_ATTR_WO(led3_mix); > + > +static struct attribute *lp5024_led_independent_attrs[] = { > + &dev_attr_led1_mix.attr, > + &dev_attr_led2_mix.attr, > + &dev_attr_led3_mix.attr, > + NULL > +}; > +ATTRIBUTE_GROUPS(lp5024_led_independent);
Ok, so you are adding new sysfs files. Are they _really_ neccessary? We'd like to have uniform interfaces for the leds.
If they are neccessary, we need documentation for them.
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |