Messages in this thread | | | From | <> | Subject | Re: [PATCH] regulator: mcp16502: Fix missing n_voltages setting | Date | Wed, 19 Dec 2018 11:45:06 +0000 |
| |
Hi Axel,
Thank you for the patch!
However, there are not MCP16502_VSEL + 1 voltages, but VDD_HIGH_SEL - VDD_LOW_SEL + 1 (=51).
Best regards, Andrei
On 19.12.2018 10:58, Axel Lin wrote: > The n_voltages setting is not set, fix it. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/regulator/mcp16502.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c > index 25d7b433fafd..ec5b6836a20c 100644 > --- a/drivers/regulator/mcp16502.c > +++ b/drivers/regulator/mcp16502.c > @@ -90,6 +90,7 @@ static unsigned int mcp16502_of_map_mode(unsigned int mode) > .ops = &(_ops), \ > .type = REGULATOR_VOLTAGE, \ > .owner = THIS_MODULE, \ > + .n_voltages = MCP16502_VSEL + 1, \ > .linear_ranges = _ranges, \ > .n_linear_ranges = ARRAY_SIZE(_ranges), \ > .of_match = of_match_ptr(_name), \
| |