Messages in this thread | | | Date | Mon, 17 Dec 2018 12:38:47 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH v13 19/25] kasan: add hooks implementation for tag-based mode |
| |
On Mon, 17 Dec 2018 20:33:42 +0100 Andrey Konovalov <andreyknvl@google.com> wrote:
> > Curiosity, did you try your patches with SLUB red zoning enabled? > > Since the area used for the Redzone is just after the payload, aligning the > > object_size independently from the allocator could have side effects, at least > > if I understand well how the mechanism works. > > > > Setting ARCH_SLAB_MINALIGN should avoid this as well. > > > > What do you think? > > Sounds good to me. > > Andrew, how should proceed with this? Send another fixup patch or > resend the whole series?
It depends on how extensive the changes are. I prefer a fixup, but at some point it's time to drop it all and start again.
| |