Messages in this thread | | | From | "Wentland, Harry" <> | Subject | Re: [WIP PATCH 01/15] drm/dp_mst: Remove bogus conditional in drm_dp_update_payload_part1() | Date | Mon, 17 Dec 2018 20:09:03 +0000 |
| |
On 2018-12-14 3:42 a.m., Daniel Vetter wrote: > On Thu, Dec 13, 2018 at 08:25:30PM -0500, Lyude Paul wrote: >> There's no reason we need this, it's just confusing looking. >> >> Signed-off-by: Lyude Paul <lyude@redhat.com> >> Cc: Juston Li <juston.li@intel.com> >> --- >> drivers/gpu/drm/drm_dp_mst_topology.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c >> index ad0fb6d003be..9b1b5c9b1fa0 100644 >> --- a/drivers/gpu/drm/drm_dp_mst_topology.c >> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c >> @@ -1896,9 +1896,7 @@ int drm_dp_update_payload_part1(struct drm_dp_mst_topology_mgr *mgr) >> req_payload.num_slots = 0; >> } >> >> - if (mgr->payloads[i].start_slot != req_payload.start_slot) { >> - mgr->payloads[i].start_slot = req_payload.start_slot; >> - } >> + mgr->payloads[i].start_slot = req_payload.start_slot; > > Entertaining! > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> >
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
>> /* work out what is required to happen with this payload */ >> if (mgr->payloads[i].num_slots != req_payload.num_slots) { >> >> -- >> 2.19.2 >> >
| |