lkml.org 
[lkml]   [2018]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] checkpatch: add Co-Developed-by to signature tags
    From
    Date
    On 12/14/18 16:52, Joe Perches wrote:

    >
    > A couple variants have been documented and only
    > one should actually be used.
    >
    > $ git grep -i co-developed-by Documentation/process/
    > Documentation/process/5.Posting.rst: - Co-developed-by: states that the patch was also created by another developer
    > Documentation/process/submitting-patches.rst:12) When to use Acked-by:, Cc:, and Co-Developed-by:
    > Documentation/process/submitting-patches.rst:A Co-Developed-by: states that the patch was also created by another developer
    >
    > $ git log --grep="co-developed-by:" -i | \
    > grep -ohiP "co-developed-by:" | sort | uniq -c | sort -rn
    > 80 Co-developed-by:
    > 40 Co-Developed-by:
    >
    > So which should it be?
    >
    > btw: I prefer neither as I think Signed-off-by: is sufficient

    IMO neither is only an option if you comfortable with the script
    generating false warnings.

    If you wont apply the patch anyway I wont pursue it further.
    Otherwise please let me know I will also update the documentation to
    match the commit.

    TIA


    > .
    >
    >> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
    > []
    >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    > []
    >> @@ -468,6 +468,7 @@ our $logFunctions = qr{(?x:
    >>
    >> our $signature_tags = qr{(?xi:
    >> Signed-off-by:|
    >> + Co-Developed-by:|
    >> Acked-by:|
    >> Tested-by:|
    >> Reviewed-by:|
    >

    \
     
     \ /
      Last update: 2018-12-14 17:06    [W:4.791 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site