Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 14 Dec 2018 16:06:17 +0100 | Subject | Re: [PATCH] gpiolib: Fix return value of gpio_to_desc() stub if !GPIOLIB |
| |
On Thu, Dec 6, 2018 at 10:45 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> If CONFIG_GPOILIB is not set, the stub of gpio_to_desc() should return > the same type of error as regular version: NULL. All the callers > compare the return value of gpio_to_desc() against NULL, so returned > ERR_PTR would be treated as non-error case leading to dereferencing of > error value. > > Fixes: 79a9becda894 ("gpiolib: export descriptor-based GPIO interface") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Patch applied. I kept the Fixes but removed stable, I do not know of any regression it is fixing.
Yours, Linus Walleij
| |