Messages in this thread | | | From | Måns Rullgård <> | Subject | Re: [PATCH] auxdisplay: charlcd: fix x/y command parsing | Date | Fri, 14 Dec 2018 12:15:47 +0000 |
| |
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes:
> Hi Måns, > > On Thu, Dec 6, 2018 at 1:06 PM Måns Rullgård <mans@mansr.com> wrote: >> >> >> BTW, the parsing of this command has been broken since 3.2-rc1 due to >> >> commit 129957069e6a. >> > >> > Thanks for checking! Are you able to test this? >> >> Yes, that's how I noticed it was broken. > > Fantastic, thank you. > > Can you please add the explanation about commit 129957069e6a > ("staging: panel: Fixed checkpatch warning about simple_strtoul()") in > the commit message so that we don't lose it? I will pick it into > linux-next.
The bad code from that commit was already completely replaced with the new parse_xy() function.
-- Måns Rullgård
| |