lkml.org 
[lkml]   [2018]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 87/89] ALSA: fireface: fix reference to wrong register for clock configuration
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Sakamoto <o-takashi@sakamocchi.jp>

    commit fa9c98e4b975bb3192ed6af09d9fa282ed3cd8a0 upstream.

    In an initial commit, 'SYNC_STATUS' register is referred to get
    clock configuration, however this is wrong, according to my local
    note at hand for reverse-engineering about packet dump. It should
    be 'CLOCK_CONFIG' register. Actually, ff400_dump_clock_config()
    is correctly programmed.

    This commit fixes the bug.

    Cc: <stable@vger.kernel.org> # v4.12+
    Fixes: 76fdb3a9e13a ('ALSA: fireface: add support for Fireface 400')
    Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/firewire/fireface/ff-protocol-ff400.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/firewire/fireface/ff-protocol-ff400.c
    +++ b/sound/firewire/fireface/ff-protocol-ff400.c
    @@ -30,7 +30,7 @@ static int ff400_get_clock(struct snd_ff
    int err;

    err = snd_fw_transaction(ff->unit, TCODE_READ_QUADLET_REQUEST,
    - FF400_SYNC_STATUS, &reg, sizeof(reg), 0);
    + FF400_CLOCK_CONFIG, &reg, sizeof(reg), 0);
    if (err < 0)
    return err;
    data = le32_to_cpu(reg);

    \
     
     \ /
      Last update: 2018-12-14 13:12    [W:4.180 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site