lkml.org 
[lkml]   [2018]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] acpi / apei: fix NULL deref during init
    From
    Date
    On 12/14/18 21:24, Borislav Petkov wrote:
    >
    > Because apei_resources_fini() happens under the same condition check and
    > if arch_apei_filter_addr was false, it should not become true, all of a
    > sudden. Or?

    Hi Borislav,

    please take a look at the stacktrace. For some reason, and only at that
    specific hardware, the condition is false, there but later the indicated
    error exit is taken whose message you can see immediately before the
    stack trace.

    So this should documents the one observed case where the NULL deref is
    actually happening.

    Of course, it would be possible to develop another solution, but this
    one appears the simplest and safest to me (minimum changes to the logic).

    I have tested the patch on that specifc hardware: I have verified that
    the patch does not trigger the NULL deref anymore.

    Of course, on any other hardware we have tested, the bug did not trigger
    at all.

    If you don't have that specific hardware, you probably cannot easily
    trigger / verify the problem.

    If you need access to the specfic hardware, talk to me in a private
    conversation.

    Cheers,

    Thomas

    \
     
     \ /
      Last update: 2018-12-14 22:28    [W:5.742 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site