Messages in this thread | | | Date | Thu, 13 Dec 2018 17:14:23 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary mode |
| |
On Wed, Dec 12, 2018 at 06:51:19PM -0800, Joe Perches wrote: > On Wed, 2018-12-12 at 13:14 -0500, Jeremy Cline wrote: > > It might be worth noting this fixes commit 6f4d29df66ac > > ("scripts/spdxcheck.py: make python3 compliant") > > umm, how does it do that? > > > and also Cc this for > > stable since 6f4d29df66ac got backported to v4.19. While that commit > > did indeed make the script work with Python 3 for piping data, it broke > > Python 2 and made its way to stable. > > I think attempting to use spdxcheck on binary files > is not useful in the first place.
Agreed. However, if run without arguments the tool will walk the entire tree and inevitably run into binary files. I realize that this is kind of a lame way of dealing with binary files, but the alternatives would be much more complicated and involve dealing with mimetypes and such.
Thierry [unhandled content-type:application/pgp-signature] | |