Messages in this thread | | | Subject | Re: [PATCH] opp: Add API for getting voltage from supplies | From | Nick Fan <> | Date | Thu, 13 Dec 2018 18:36:52 +0800 |
| |
On Thu, 2018-12-13 at 12:08 +0530, Viresh Kumar wrote: > On 10-12-18, 20:36, Nick Fan wrote: > > For the users who only use one supply, they can use > > dev_pm_opp_get_voltage to get the voltage data from an opp. > > But if the users who use more than one supply, they will need this API > > to get their voltage data from OPP. > > The users should know about the supply count while creating opp table by > > using dev_pm_opp_set_regulators function. > > By using this API, the users can get the voltages by using index to > > specify which supplies they want. > > > > The following is a simple example to get multiple regulators by this > > API. > > for (i = 0; i < regulator_num; i++) > > target_volt[i] = dev_pm_opp_get_voltage_supply(opp, i); > > Fair enough. I couldn't find anything wrong with the patch. Will it be > possible to send this patch as part of a series which uses the new API > ? So that we are sure of somebody using it eventually. > This new API is suitable for the users that required to access for multiple regulators. And I am one of users who uses this API, but I am not able to upstream the GPU kernel driver which uses the new API.
-- Nick Fan
| |