Messages in this thread | | | From | Frank Lee <> | Date | Thu, 13 Dec 2018 00:41:13 +0800 | Subject | Re: [PATCH] bpf: convert to DEFINE_SHOW_ATTRIBUTE |
| |
On Tue, Dec 11, 2018 at 2:22 AM Jakub Kicinski <jakub.kicinski@netronome.com> wrote: > > On Mon, 10 Dec 2018 11:03:27 -0500, Yangtao Li wrote: > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com> > > Please post v2 with the subject prefix set to "netdevsim:" rather than > "bpf:". The newer has been sent.
Thanks, Yangtao > > > drivers/net/netdevsim/bpf.c | 16 ++-------------- > > 1 file changed, 2 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/net/netdevsim/bpf.c b/drivers/net/netdevsim/bpf.c > > index cb3518474f0e..14b4d9774708 100644 > > --- a/drivers/net/netdevsim/bpf.c > > +++ b/drivers/net/netdevsim/bpf.c > > @@ -48,7 +48,7 @@ struct nsim_bpf_bound_map { > > struct list_head l; > > }; > > > > -static int nsim_debugfs_bpf_string_read(struct seq_file *file, void *data) > > +static int nsim_bpf_string_show(struct seq_file *file, void *data) > > { > > const char **str = file->private; > > > > @@ -57,19 +57,7 @@ static int nsim_debugfs_bpf_string_read(struct seq_file *file, void *data) > > > > return 0; > > } > > - > > -static int nsim_debugfs_bpf_string_open(struct inode *inode, struct file *f) > > -{ > > - return single_open(f, nsim_debugfs_bpf_string_read, inode->i_private); > > -} > > - > > -static const struct file_operations nsim_bpf_string_fops = { > > - .owner = THIS_MODULE, > > - .open = nsim_debugfs_bpf_string_open, > > - .release = single_release, > > - .read = seq_read, > > - .llseek = seq_lseek > > -}; > > +DEFINE_SHOW_ATTRIBUTE(nsim_bpf_string); > > > > static int > > nsim_bpf_verify_insn(struct bpf_verifier_env *env, int insn_idx, int prev_insn) >
| |