lkml.org 
[lkml]   [2018]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 09/73] net: phy: sfp: correct store of detected link modes
    Date
    From: Baruch Siach <baruch@tkos.co.il>

    [ Upstream commit d7f7e0018b96fd1a30a968faa9464eb57372c1ec ]

    The link modes that sfp_parse_support() detects are stored in the
    'modes' bitmap. There is no reason to make an exception for 1000Base-PX
    or 1000Base-BX10.

    Fixes: 03145864bd0f ("sfp: support 1G BiDi (eg, FiberStore SFP-GE-BX) modules")
    Signed-off-by: Baruch Siach <baruch@tkos.co.il>
    Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/phy/sfp-bus.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
    index 83060fb349f4..ad9db652874d 100644
    --- a/drivers/net/phy/sfp-bus.c
    +++ b/drivers/net/phy/sfp-bus.c
    @@ -162,7 +162,7 @@ void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
    /* 1000Base-PX or 1000Base-BX10 */
    if ((id->base.e_base_px || id->base.e_base_bx10) &&
    br_min <= 1300 && br_max >= 1200)
    - phylink_set(support, 1000baseX_Full);
    + phylink_set(modes, 1000baseX_Full);

    /* For active or passive cables, select the link modes
    * based on the bit rates and the cable compliance bytes.
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-13 05:52    [W:2.928 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site