lkml.org 
[lkml]   [2018]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 49/73] net/mlx4_en: Fix build break when CONFIG_INET is off
    Date
    From: Saeed Mahameed <saeedm@mellanox.com>

    [ Upstream commit 1b603f9e4313348608f256b564ed6e3d9e67f377 ]

    MLX4_EN depends on NETDEVICES, ETHERNET and INET Kconfigs.
    Make sure they are listed in MLX4_EN Kconfig dependencies.

    This fixes the following build break:

    drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: ‘struct iphdr’ declared inside parameter list [enabled by default]
    struct iphdr *iph)
    ^
    drivers/net/ethernet/mellanox/mlx4/en_rx.c:582:18: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
    drivers/net/ethernet/mellanox/mlx4/en_rx.c: In function ‘get_fixed_ipv4_csum’:
    drivers/net/ethernet/mellanox/mlx4/en_rx.c:586:20: error: dereferencing pointer to incomplete type
    _u8 ipproto = iph->protocol;

    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx4/Kconfig | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx4/Kconfig b/drivers/net/ethernet/mellanox/mlx4/Kconfig
    index 36054e6fb9d3..f200b8c420d5 100644
    --- a/drivers/net/ethernet/mellanox/mlx4/Kconfig
    +++ b/drivers/net/ethernet/mellanox/mlx4/Kconfig
    @@ -5,7 +5,7 @@
    config MLX4_EN
    tristate "Mellanox Technologies 1/10/40Gbit Ethernet support"
    depends on MAY_USE_DEVLINK
    - depends on PCI
    + depends on PCI && NETDEVICES && ETHERNET && INET
    select MLX4_CORE
    imply PTP_1588_CLOCK
    ---help---
    --
    2.19.1
    \
     
     \ /
      Last update: 2018-12-13 05:48    [W:4.069 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site