lkml.org 
[lkml]   [2018]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros
Date
> On Nov 29, 2018, at 8:43 AM, Logan Gunthorpe <logang@deltatee.com> wrote:
>
>
>
> On 2018-11-28 6:31 p.m., Nadav Amit wrote:
>>> On Nov 28, 2018, at 4:49 PM, Logan Gunthorpe <logang@deltatee.com> wrote:
>>>
>>>
>>>
>>> On 2018-11-28 5:38 p.m., Nadav Amit wrote:
>>>> So what’s your take? Would you think this patch is still needed? Should it
>>>> only be enabled automatically for distcc and not for distcc-pump?
>>>
>>> Not sure. The patch will probably slow things down a lot (seeing
>>> assembly is always done locally and there are twice as many compile
>>> steps) and will create some confusion once it's possible to disable it
>>> for the new versions. Maybe hold off and see if anyone else complains?
>>>
>>> I don't really know how you'd detect whether pump is in use or not and
>>> I'm uncertain as to whether any of the auto detection can actually be
>>> made to be reliable.
>>
>> A silly `$(CC) —version | grep pump ` test.
>
> Actually I'm not sure that's going to work in all cases. If CC="distcc
> gcc", then "$(CC) --version" just looks like "gcc --version"...

Err.. You’re right. I just tried distcc --version.

\
 
 \ /
  Last update: 2018-12-01 07:30    [W:2.257 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site