Messages in this thread | | | From | Deepa Dinamani <> | Date | Fri, 30 Nov 2018 14:38:27 -0800 | Subject | Re: [PATCH 2/8] sockopt: Rename SO_TIMESTAMP* to SO_TIMESTAMP*_OLD |
| |
On Sat, Nov 24, 2018 at 7:59 PM Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote: > > On Sat, Nov 24, 2018 at 3:58 AM Deepa Dinamani <deepa.kernel@gmail.com> wrote: > > > > SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING options, the > > way they are currently defined, are not y2038 safe. > > Subsequent patches in the series add new y2038 safe versions > > of these options which provide 64 bit timestamps on all > > architectures uniformly. > > Hence, rename existing options with OLD tag suffixes. > > Why do the existing interfaces have to be renamed when new interfaces are added?
Existing options need to be renamed because of the macro below:
#define SO_TIMESTAMP (sizeof(time_t) == sizeof(__kernel_long_t) ? \ SO_TIMESTAMP_OLD : SO_TIMESTAMP_NEW)
SO_TIMESTAMP is now dependent on size of time_t because of the libc flag.
-Deepa
| |