lkml.org 
[lkml]   [2018]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] pinctrl: generic: Avoid several implicit enum conversions
    On Thu, Nov 1, 2018 at 1:03 AM Nathan Chancellor
    <natechancellor@gmail.com> wrote:
    > [Me]
    > > A slightly lesser evil variant is to add a few PIN_CONFIG_CUSTOM_1
    > > PIN_CONFIG_CUSTOM_2 etc at the end of the enum and just
    > > #define MY_CONFIG PIN_CONFIG_CUSTOM_1
    > > in all drivers that use these.
    > >
    >
    > Some drivers actually just define their pin config params like:
    >
    > #define VAR (PIN_CONFIG_END + 1)
    >
    > In fact, more drivers do that than not. I will go ahead and draft some
    > patches tonight and send them out tonight to see what driver authors
    > think.

    This seems to work. Is your kernel compile working without
    warnings after this round of patches?

    Thanks for driving this BTW.

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2018-11-09 10:30    [W:5.720 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site