Messages in this thread |  | | From | "Chanho Min" <> | | Subject | RE: [PATCH] freezer: fix freeze timeout on exec | | Date | Fri, 9 Nov 2018 16:50:33 +0900 |
| |
> > > > Can't we simply change de_thread() to use freezable_schedule() ? > > > > Oleg. > > We need to change freezable_schedule_timeout() instead. > freezable_schedule also can't be frozen if sub-threads can't stop > schedule(). > Furthermore, I'm not sure if it is safe to freeze it at de_thread(). > > diff --git a/fs/exec.c b/fs/exec.c > index 9c5ee2a..291cbd6 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -942,7 +942,7 @@ static int de_thread(struct task_struct *tsk) > while (sig->notify_count) { > __set_current_state(TASK_KILLABLE); > spin_unlock_irq(lock); > - schedule(); > + while (!freezable_schedule_timeout(HZ)); > if (unlikely(__fatal_signal_pending(tsk))) > goto killed; > spin_lock_irq(lock); > > Chanho
Sorry, I might misunderstand freezer. Changes to freezable_schedule() works fine. It looks safe. I'll apply patch again.
Chanho
|  |