Messages in this thread | | | From | Kyle Roeschley <> | Subject | Re: [PATCH] net: phy: leds: Don't make our own link speed names | Date | Thu, 8 Nov 2018 19:32:28 +0000 |
| |
On Thu, Nov 08, 2018 at 09:59:53AM -0800, Florian Fainelli wrote: > On 11/8/18 9:51 AM, Kyle Roeschley wrote: > > The phy core provides a handy phy_speed_to_str() helper, so use that > > instead of doing our own formatting of the different known link speeds. > > In case the speed is not supported, phy_speed_to_str() would return > "Unsupported (update phy-core.c)" which is bigger (by 21 characters) > than name_suffix. > > If you bumped name_suffix/PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE to 11 > characters, that would be just large enough to accommodate for the > "Unsupported" part of the string and that might be an acceptable > solution in between. >
Thanks for catching that, I'll send a v2.
-- Kyle Roeschley Software Engineer National Instruments
| |