lkml.org 
[lkml]   [2018]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 132/171] Revert "netfilter: ipv6: nf_defrag: drop skb dst before queueing"
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    This reverts commit ad8b1ffc3efae2f65080bdb11145c87d299b8f9a.

    >From Florian Westphal <fw@strlen.de>:

    It causes kernel crash for locally generated ipv6 fragments
    when netfilter ipv6 defragmentation is used.

    The faulty commit is not essential for -stable, it only
    delays netns teardown for longer than needed when that netns
    still has ipv6 frags queued. Much better than crash :-/

    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/ipv6/netfilter/nf_conntrack_reasm.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c
    index b9147558a8f2..e46185377981 100644
    --- a/net/ipv6/netfilter/nf_conntrack_reasm.c
    +++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
    @@ -597,8 +597,6 @@ int nf_ct_frag6_gather(struct net *net, struct sk_buff *skb, u32 user)
    fq->q.meat == fq->q.len &&
    nf_ct_frag6_reasm(fq, skb, dev))
    ret = 0;
    - else
    - skb_dst_drop(skb);

    out_unlock:
    spin_unlock_bh(&fq->q.lock);
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-08 23:19    [W:3.284 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site