Messages in this thread | | | Date | Fri, 9 Nov 2018 03:12:25 -0800 | From | Greg KH <> | Subject | Re: [PATCH v2] x86/cpu: fix prototype warning |
| |
On Fri, Nov 09, 2018 at 11:55:38AM +0100, Borislav Petkov wrote: > On Fri, Nov 09, 2018 at 08:43:12AM +0800, wang.yi59@zte.com.cn wrote: > > Yeah, so that is. However, I suppose we should not enable this by default > > before we fix ALL of these warning, > > Yeah, the build is really noisy now. > > > which is really a hard work. :) > > Yeah, I wonder if adding this to a kernel janitors TODO list or somesuch > would help speeding up the process. > > Maybe Greg knows. > > Greg, the question is whether we can get people to help out with > > -Wmissing-prototypes > > fixes around the tree. Currently, there are ~1400 warnings and we want > to have 0 and then add that option to the main Makefile. > > It is very easy to do: you simply build the kernel with W=1, choose one > -Wmissing-prototypes warning and fix it by adding a function prototype > or declaring the function static. > > It should be a pretty easy for newbies to get involved...
Sure, sounds like a good task. Post it to the driverdevel mailing list and see if people are interested.
thanks,
greg k-h
| |