Messages in this thread | | | Subject | Re: [PATCH 1/4] of/device: Add a way to probe drivers by match data | From | Matthias Brugger <> | Date | Fri, 9 Nov 2018 11:29:34 +0100 |
| |
On 08/11/2018 18:58, Stephen Boyd wrote: > Quoting Matthias Brugger (2018-11-08 00:29:46) >> On 06/11/2018 19:36, Stephen Boyd wrote: >>> +int platform_driver_probe_by_of_match_data(struct platform_device *pdev) >>> +{ >>> + int (*probe_func)(struct platform_device *pdev); >>> + >>> + probe_func = of_device_get_match_data(&pdev->dev); >> >> Shouldn't we check if probe_func is not NULL? > > Is the oops from the NULL pointer deref insufficient? >
Do you think we should crash the machine if someone uses the call wrongly? Or should we provide the possibility to error out on the caller side?
Regards, Matthias
| |