lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv10 3/8] firmware: add Intel Stratix10 service layer driver
From
Date
Hi Randy,

On 11/6/18 11:03 AM, Randy Dunlap wrote:
> On 11/6/18 8:52 AM, richard.gong@linux.intel.com wrote:
>> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
>> index 7273e50..b6813bc 100644
>> --- a/drivers/firmware/Kconfig
>> +++ b/drivers/firmware/Kconfig
>> @@ -216,6 +216,18 @@ config FW_CFG_SYSFS_CMDLINE
>> WARNING: Using incorrect parameters (base address in particular)
>> may crash your system.
>>
>> +config INTEL_STRATIX10_SERVICE
>> + tristate "Intel Stratix10 Service Layer"
>> + depends on HAVE_ARM_SMCCC
>> + default n
>> + help
>> + Intel Stratix10 service layer runs at privileged exception level,
>> + interfaces with the service providers (FPGA manager is one of them) and
>> + manages secure monitor call to communicate with secure monitor software
>> + at secure monitor exception level.
>> +
>> + Say Y here if you want Stratix10 service layer support.
>
> from Documentation/process/coding-style.rst:
>
> Lines under a ``config`` definition are indented with one tab,
> while help text is indented an additional two spaces.
>
>

I will correct that in the next submission.

> thanks.
>

Regards,
Richard

\
 
 \ /
  Last update: 2018-11-07 21:39    [W:0.068 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site