lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure
    From
    Date


    On 11/07/2018 03:48 PM, Michal Hocko wrote:
    > From: Michal Hocko <mhocko@suse.com>
    >
    > The memory offlining failure reporting is inconsistent and insufficient.
    > Some error paths simply do not report the failure to the log at all.
    > When we do report there are no details about the reason of the failure
    > and there are several of them which makes memory offlining failures
    > hard to debug.
    >
    > Make sure that the
    > memory offlining [mem %#010llx-%#010llx] failed
    > message is printed for all failures and also provide a short textual
    > reason for the failure e.g.
    >
    > [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000-0x8267fffffff] failed due to signal backoff
    >
    > this tells us that the offlining has failed because of a signal pending
    > aka user intervention.
    >
    > Signed-off-by: Michal Hocko <mhocko@suse.com>

    It might help to enumerate these failure reason strings and use macros.

    \
     
     \ /
      Last update: 2018-11-08 07:24    [W:4.705 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site