lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] Revert "scripts/setlocalversion: git: Make -dirty check more robust"
    On Wed, Nov 7, 2018 at 1:18 PM Doug Anderson <dianders@chromium.org> wrote:
    > On Wed, Nov 7, 2018 at 1:07 PM Genki Sky <sky@genki.is> wrote:
    > > On Wed, 7 Nov 2018 12:55:14 -0800, Guenter Roeck <linux@roeck-us.net> wrote:
    > > > Ubuntu 16.04 ships with git version 2.7.4.
    > >
    > > Okay. I guess --no-optional-locks is a no-go then.
    >
    > In theory you could wrap it. If passing git with
    > "--no-optional-locks" doesn't work you could fall back to the old
    > code? That would mean only people with newer git would get your new
    > feature and everyone else would stick with the pre-existing behavior.

    +1, that's what I was going to suggest. Presumably older git would
    give non-zero exit status for unknown flags, and we take that as
    signal to try to the old way?

    \
     
     \ /
      Last update: 2018-11-08 04:17    [W:5.112 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site