lkml.org 
[lkml]   [2018]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v14 05/12] cpuset: Add an error state to cpuset.sched.partition
From
Date
On 11/06/2018 06:40 AM, Peter Zijlstra wrote:
> On Mon, Oct 15, 2018 at 04:29:30PM -0400, Waiman Long wrote:
>> + spin_lock_irq(&callback_lock);
>> + clear_bit(CS_CPU_EXCLUSIVE, &cp->flags);
>> + spin_unlock_irq(&callback_lock);
> A single atomic bitop wrapped in a spinlock.. maybe it is correct, but
> it looks suspicous.

Yes, you are right. The spin_lock() should not be needed in this case.

Thanks,
Longman

\
 
 \ /
  Last update: 2018-11-08 00:14    [W:0.044 / U:2.440 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site