Messages in this thread | | | Subject | Re: [PATCH v15 12/12] cpuset: Expose cpuset.cpus.subpartitions with cgroup_debug | From | Waiman Long <> | Date | Thu, 8 Nov 2018 13:59:43 -0500 |
| |
On 11/08/2018 10:46 AM, Peter Zijlstra wrote: > On Thu, Nov 08, 2018 at 10:08:46AM -0500, Waiman Long wrote: >> For debugging purpose, it will be useful to expose the content of the >> subparts_cpus as a read-only file to see if the code work correctly. >> However, subparts_cpus will not be used at all in most use cases. So >> adding a new cpuset file that clutters the cgroup directory may not be >> desirable. This is now being done by using the hidden "cgroup_debug" >> kernel command line option to expose a new "cpuset.cpus.subpartitions" >> file. > One thought I had; would it make sense to make these debug files hidden > ("." prefix) ?
These debug files will only appear when the cgroup_debug command line option is used. So I don't think we really need to add an extra "." prefix as it will break the naming convention.
Cheers, Longman
| |