lkml.org 
[lkml]   [2018]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] regulator: bd71837: add <linux/of.h> to fix build errors
    From
    Date
    On 10/25/18 11:02 PM, Vaittinen, Matti wrote:
    > Hello,
    >
    > From: Randy Dunlap <rdunlap@infradead.org>
    >
    >> Fix build error due to missing header file:
    >>
    >> drivers/regulator/bd71837-regulator.c:242:3: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration]
    >>
    >> Fixes: ba08799e90b5 ("regulator: bd71837: BD71837 PMIC regulator driver")
    >
    > //snip
    >
    >> --- lnx-419.orig/drivers/regulator/bd71837-regulator.c
    >> +++ lnx-419/drivers/regulator/bd71837-regulator.c
    >> @@ -9,6 +9,7 @@
    >> #include <linux/kernel.h>
    >> #include <linux/mfd/rohm-bd718x7.h>
    >> #include <linux/module.h>
    >> +#include <linux/of.h>
    >> #include <linux/platform_device.h>
    >> #include <linux/regulator/driver.h>
    >> #include <linux/regulator/machine.h>
    >
    > Not sure if this is relevant but if I am not mistaken this should already be fixed by:
    > df43519eb706edfe951284a825642ce2e1d38d09
    > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=df43519eb706edfe951284a825642ce2e1d38d09
    >
    >
    > Br,
    > Matti Vaittinen
    >

    Hi,

    It seems that this same patch is now needed in
    drivers/regulator/bd718x7-regulator.c:

    From linux-next-2018-11-07:

    file: drivers/regulator/bd718x7-regulator.c: errors: 109, warnings: 0

    This is a small sample of the errors:

    CC [M] drivers/regulator/bd718x7-regulator.o
    ../drivers/regulator/bd718x7-regulator.c:355:4: error: implicit declaration of function ‘of_match_ptr’ [-Werror=implicit-function-declaration]
    .of_match = of_match_ptr("BUCK1"),
    ^
    ../drivers/regulator/bd718x7-regulator.c:355:4: error: initializer element is not constant
    ../drivers/regulator/bd718x7-regulator.c:355:4: error: (near initialization for ‘bd71847_regulators[0].desc.of_match’)
    ../drivers/regulator/bd718x7-regulator.c:356:4: error: initializer element is not constant
    .regulators_node = of_match_ptr("regulators"),
    ^
    ../drivers/regulator/bd718x7-regulator.c:356:4: error: (near initialization for ‘bd71847_regulators[0].desc.regulators_node’)
    ../drivers/regulator/bd718x7-regulator.c:379:4: error: initializer element is not constant
    .of_match = of_match_ptr("BUCK2"),
    ^


    thanks,
    --
    ~Randy

    \
     
     \ /
      Last update: 2018-11-07 17:39    [W:5.894 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site