lkml.org 
[lkml]   [2018]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP
From
Date
Hi Matthew,

Thank for your feedback.

On 29/10/18 13:41, Matthew Wilcox wrote:
> On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote:
>> +config DW_I3C_MASTER
>> + tristate "Synospsys DesignWare I3C master driver"
>> + depends on I3C
>> + depends on !(ALPHA || PARISC)
> why?

Please check this email thread: https://lkml.org/lkml/2018/10/8/393

>
>> + help
>> + Support·for·Synopsys·DesignWare·MIPI·I3C·Controller.
> These strange characters (displayed as a centred dot on my terminal)
> should probably be spaces.

Something went wrong here. I need to check it.

>
>> +static struct dw_i3c_xfer *
>> +dw_i3c_master_alloc_xfer(struct dw_i3c_master *master, unsigned int ncmds)
>> +{
>> + struct dw_i3c_xfer *xfer;
>> +
>> + xfer = kzalloc(sizeof(*xfer) + (ncmds * sizeof(*xfer->cmds)),
>> + GFP_KERNEL);
> You should be using struct_size() here.

This seem to be recent. I will use it next version :D

Best regards,
Vitor Soares

\
 
 \ /
  Last update: 2018-11-07 16:16    [W:0.093 / U:1.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site