Messages in this thread | | | Subject | Re: [PATCH] block: respect virtual boundary mask in bvecs | From | Johannes Thumshirn <> | Date | Tue, 6 Nov 2018 15:56:00 +0100 |
| |
On 06/11/2018 15:53, Bart Van Assche wrote: > How about changing that expression into the following to make it easier > for the compiler to optimize this code? > > (offset | (bprv->bv_offset + bprv->bv_len)) & queue_virt_boundary(q)
Uhm I have to admit I'm not really able to parse the above expression. Sure GCC will do it but I think it's less readable (at least for me). Let's see what other's think.
Thanks, Johannes -- Johannes Thumshirn SUSE Labs jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
| |