lkml.org 
[lkml]   [2018]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 04/12] cpuset: Add new v2 cpuset.sched.partition flag
On Mon, Oct 15, 2018 at 04:29:29PM -0400, Waiman Long wrote:
> + * Called with cpuset_mutex held.
> + */
> +static int update_parent_subparts_cpumask(struct cpuset *cpuset, int cmd,
> + struct cpumask *newmask,
> + struct tmpmasks *tmp)
> +{
> + struct cpuset *parent = parent_cs(cpuset);
> + int adding; /* Moving cpus from effective_cpus to subparts_cpus */
> + int deleting; /* Moving cpus from subparts_cpus to effective_cpus */
> +

I much prefer doing away with that "called with * held" comment crud and
add:

lockdep_assert_held(&cpuset_mutex);


\
 
 \ /
  Last update: 2018-11-06 12:36    [W:0.153 / U:38.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site