Messages in this thread | | | Date | Tue, 6 Nov 2018 12:35:38 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v14 04/12] cpuset: Add new v2 cpuset.sched.partition flag |
| |
On Mon, Oct 15, 2018 at 04:29:29PM -0400, Waiman Long wrote: > + * Called with cpuset_mutex held. > + */ > +static int update_parent_subparts_cpumask(struct cpuset *cpuset, int cmd, > + struct cpumask *newmask, > + struct tmpmasks *tmp) > +{ > + struct cpuset *parent = parent_cs(cpuset); > + int adding; /* Moving cpus from effective_cpus to subparts_cpus */ > + int deleting; /* Moving cpus from subparts_cpus to effective_cpus */ > +
I much prefer doing away with that "called with * held" comment crud and add:
lockdep_assert_held(&cpuset_mutex);
| |