lkml.org 
[lkml]   [2018]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers
On 11/5/18, Al Cooper <alcooperx@gmail.com> wrote:

> +
> +config USB_BRCM
> + tristate "Broadcom STB USB support"
> + depends on ARCH_BRCMSTB
> + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> + select USB_EHCI_BRCM if USB_EHCI_HCD
> + select USB_XHCI_BRCM if USB_XHCI_HCD
> + select USB_XHCI_PLATFORM if USB_XHCI_HCD
> + select BRCM_USB_PHY if USB_OHCI_HCD || USB_EHCI_HCD || USB_XHCI_HCD
> + select GENERIC_PHY if BRCM_USB_PHY
> + default ARCH_BRCMSTB

Is there a build time dependency on the PHY layer? If not, I would suggest
dropping the last two 'select' statements. I would also suggest
making the dependency 'depends on ARCH_BRCMSTB || COMPILE_TEST'
to allow building it on other architecture for better build testing, and
dropping the 'default' line. Just add this to the defconfig like the other
drivers you have.

Arnd

\
 
 \ /
  Last update: 2018-11-06 12:11    [W:0.118 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site