Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 6 Nov 2018 12:09:47 +0100 | Subject | Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers |
| |
On 11/5/18, Al Cooper <alcooperx@gmail.com> wrote:
> + > +config USB_BRCM > + tristate "Broadcom STB USB support" > + depends on ARCH_BRCMSTB > + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > + select USB_EHCI_BRCM if USB_EHCI_HCD > + select USB_XHCI_BRCM if USB_XHCI_HCD > + select USB_XHCI_PLATFORM if USB_XHCI_HCD > + select BRCM_USB_PHY if USB_OHCI_HCD || USB_EHCI_HCD || USB_XHCI_HCD > + select GENERIC_PHY if BRCM_USB_PHY > + default ARCH_BRCMSTB
Is there a build time dependency on the PHY layer? If not, I would suggest dropping the last two 'select' statements. I would also suggest making the dependency 'depends on ARCH_BRCMSTB || COMPILE_TEST' to allow building it on other architecture for better build testing, and dropping the 'default' line. Just add this to the defconfig like the other drivers you have.
Arnd
| |