Messages in this thread | | | From | Mathieu Malaterre <> | Date | Mon, 5 Nov 2018 21:20:30 +0100 | Subject | Re: [PATCH] net: move ‘ zerocopy sg from iter’ prototype to header file <linux/skbuff.h> |
| |
On Sat, Nov 3, 2018 at 7:34 AM David Miller <davem@davemloft.net> wrote: > > From: Mathieu Malaterre <malat@debian.org> > Date: Wed, 31 Oct 2018 12:34:59 +0100 > > > This makes it clear the function is part of the API. Also this will > > remove a warning triggered at W=1: > > > > net/core/datagram.c:581:5: warning: no previous prototype for ‘__zerocopy_sg_from_iter’ [-Wmissing-prototypes] > > > > Signed-off-by: Mathieu Malaterre <malat@debian.org> > > It's not part of the "API", and it shouldn't even be exported to > modules. > > Only net/core/skbuff.c calls it, and that is never modular.
OK. I got confused with the EXPORT_SYMBOL(). I'll re-send moving __zerocopy_sg_from_iter to skbuff.c.
Thanks
| |