Messages in this thread Patch in this message | | | From | Nadav Amit <> | Subject | Re: [PATCH v9 02/10] Makefile: Prepare for using macros for inline asm | Date | Tue, 6 Nov 2018 19:18:10 +0000 |
| |
From: Logan Gunthorpe Sent: November 6, 2018 at 6:57:57 PM GMT > To: Nadav Amit <namit@vmware.com>, Ingo Molnar <mingo@redhat.com> > Cc: linux-kernel@vger.kernel.org>, x86@kernel.org>, Sam Ravnborg <sam@ravnborg.org>, Michal Marek <michal.lkml@markovi.net>, Thomas Gleixner <tglx@linutronix.de>, H. Peter Anvin <hpa@zytor.com>, linux-kbuild@vger.kernel.org>, Stephen Bates <sbates@raithlin.com> > Subject: Re: [PATCH v9 02/10] Makefile: Prepare for using macros for inline asm > > > > > On 2018-10-03 3:30 p.m., Nadav Amit wrote: >> +ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s -Wa,- >> +export ASM_MACRO_FLAGS >> +KBUILD_CFLAGS += $(ASM_MACRO_FLAGS) > > I'm not sure how much we care about this or what we can do about it, but > adding the macros.s to the command line like this has effectively broken > distributed compiling with distcc and icecc as of v4.20-rc1. Neither > tool will successfully distribute any compile processes because the > non-local machines won't have a copy of macros.s.
Err.. I don’t have a dist-cc environment. I wonder whether something like that would do the trick:
-- >8 —
Subject: [PATCH] x86: Fix dist-cc
--- arch/x86/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 5b562e464009..81d76cbcffff 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -237,9 +237,9 @@ archheaders: $(Q)$(MAKE) $(build)=arch/x86/entry/syscalls all archmacros: - $(Q)$(MAKE) $(build)=arch/x86/kernel arch/x86/kernel/macros.s + $(Q)$(MAKE) $(build)=arch/x86/kernel ${objtree}/arch/x86/kernel/macros.s -ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s -Wa,- +ASM_MACRO_FLAGS = -Wa,${objtree}/arch/x86/kernel/macros.s -Wa,- export ASM_MACRO_FLAGS KBUILD_CFLAGS += $(ASM_MACRO_FLAGS) -- 2.17.1
| |