Messages in this thread | | | Date | Tue, 6 Nov 2018 19:05:26 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH -next] edac: i82975x: remove set but not used variable 'dtype' |
| |
On Thu, Nov 01, 2018 at 10:26:04AM +0800, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/edac/i82975x_edac.c:378:16: warning: > variable ‘dtype’ set but not used [-Wunused-but-set-variable] > > It never used since introduction in commit > 084a4fccef39 ("edac: move dimm properties to struct dimm_info") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/edac/i82975x_edac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/edac/i82975x_edac.c b/drivers/edac/i82975x_edac.c > index 892815e..ae0d8fa 100644 > --- a/drivers/edac/i82975x_edac.c > +++ b/drivers/edac/i82975x_edac.c > @@ -375,7 +375,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci, > u32 cumul_size, nr_pages; > int index, chan; > struct dimm_info *dimm; > - enum dev_type dtype; > > last_cumul_size = 0; > > @@ -413,7 +412,6 @@ static void i82975x_init_csrows(struct mem_ctl_info *mci, > * [0-7] for single-channel; i.e. csrow->nr_channels = 1 > * [0-3] for dual-channel; i.e. csrow->nr_channels = 2 > */ > - dtype = i82975x_dram_type(mch_window, index);
Please get rid of that silly function too and move the comment and the assignment to the single place where it is done:
/* * ECC is possible on i92975x ONLY with DEV_X8 */ dimm->dtype = DEV_X8;
Thx.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |