lkml.org 
[lkml]   [2018]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] psi: simplify cgroup_move_task
    On Sat, Nov 03, 2018 at 11:33:39AM -0700, Olof Johansson wrote:
    > The existing code triggered an invalid warning about 'rq' possibly being
    > used uninitialized. Instead of doing the silly warning suppression by
    > initializa it to NULL, refactor the code to bail out early instead.
    >
    > Warning was:
    >
    > kernel/sched/psi.c: In function ‘cgroup_move_task’:
    > kernel/sched/psi.c:639:13: warning: ‘rq’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    >
    > Fixes: 2ce7135adc9ad ("psi: cgroup support")
    > Cc: Johannes Weiner <hannes@cmpxchg.org>
    > Signed-off-by: Olof Johansson <olof@lixom.net>

    Acked-by: Johannes Weiner <hannes@cmpxchg.org>

    Thanks Olof!

    \
     
     \ /
      Last update: 2018-11-06 17:56    [W:7.451 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site