Messages in this thread | | | Date | Tue, 6 Nov 2018 11:55:04 -0500 | From | Johannes Weiner <> | Subject | Re: [PATCH] psi: simplify cgroup_move_task |
| |
On Sat, Nov 03, 2018 at 11:33:39AM -0700, Olof Johansson wrote: > The existing code triggered an invalid warning about 'rq' possibly being > used uninitialized. Instead of doing the silly warning suppression by > initializa it to NULL, refactor the code to bail out early instead. > > Warning was: > > kernel/sched/psi.c: In function ‘cgroup_move_task’: > kernel/sched/psi.c:639:13: warning: ‘rq’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > Fixes: 2ce7135adc9ad ("psi: cgroup support") > Cc: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Thanks Olof!
| |