lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free()
    From
    Date
    On 11/5/18 12:58 AM, Aaron Lu wrote:
    > - if (unlikely(put_page_testzero(page)))
    > - __free_pages_ok(page, compound_order(page));
    > + if (unlikely(put_page_testzero(page))) {
    > + unsigned int order = compound_order(page);
    > +
    > + if (order == 0)
    > + free_unref_page(page);
    > + else
    > + __free_pages_ok(page, order);
    > + }
    > }

    This little hunk seems repeated in __free_pages() and
    __page_frag_cache_drain(). Do we need a common helper?

    \
     
     \ /
      Last update: 2018-11-05 17:39    [W:4.091 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site