lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] device property: Add fwnode_name() helper
On Mon, Nov 05, 2018 at 12:17:23PM +0300, Heikki Krogerus wrote:
> Hi,
>
> I prepared fwnode_name() for something I'm working on, but then I
> realized that it makes it possible to also implement a generic
> fwnode_get_named_child_node(). So in practice I'm proposing that we
> replace get_named_child_node fwnode op with that new "name" fwnode op
> in this series.
>

All LGTM, though consider one minor comment in patch 1.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> thanks,
>
> Heikki Krogerus (4):
> device property: Introduce fwnode_name()
> ACPI: property: Introduce acpi_fwnode_name()
> of/property: Introduce of_fwnode_name()
> device property: Drop get_named_child_node callback
>
> drivers/acpi/property.c | 26 +++++++-------------------
> drivers/base/property.c | 28 +++++++++++++++++++++++++++-
> drivers/of/property.c | 21 ++++++---------------
> include/linux/fwnode.h | 4 +---
> include/linux/property.h | 2 ++
> 5 files changed, 43 insertions(+), 38 deletions(-)
>
> --
> 2.19.1
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2018-11-05 15:38    [W:0.188 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site